chore: test against node 18 in CI #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/ci.yml
Outdated
| strategy: | ||
| matrix: | ||
| node: [18, 20] | ||
| coninue-on-error: ${{ matrix.node == 20 }} |
There was a problem hiding this comment.
Suggested change
| coninue-on-error: ${{ matrix.node == 20 }} |
Since 2nd step to upgrade to v20 was already cleared before this, we need to remove continue-on-error in order to make the Node 20 test a blocking one.
BilalQamar95
approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 28 28
Lines 412 412
Branches 87 89 +2
=======================================
Hits 292 292
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #298